Memoize the processor in MarkdownHooks #909
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some plugins may perform heavy work in preparation to make the transformer light-weight. A good example of this is `rehype-starry-night`. Without this change, an interactive markdown editor which includes `rehype-starry-night` is very sluggish. With this change, performance is as good as if `rehype-starry-night` isn’t even used.
remcohaszing
added
🏁 area/perf
6 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #909 +/- ##
==========================================
Coverage 100.00% 100.00%
==========================================
Files 3 3
Lines 1354 1743 +389
Branches 113 123 +10
==========================================
+ Hits 1354 1743 +389 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
wooorm
reviewed
Apr 19, 2025
lib/index.js
Outdated
| @@ -212,7 +212,10 @@ export async function MarkdownAsync(options) { | |||
| * React node. | |||
| */ | |||
| export function MarkdownHooks(options) { | |||
| const processor = createProcessor(options) | |||
| const processor = useMemo( | |||
| () => createProcessor(options), | |||
There was a problem hiding this comment.
please use a regular function, thanks
wooorm
approved these changes
Apr 21, 2025
This comment has been minimized.
This comment has been minimized.
|
Thanks! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial checklist
Description of changes
Some plugins may perform heavy work in preparation to make the transformer light-weight. A good example of this is
rehype-starry-night.Without this change, an interactive markdown editor which includes
rehype-starry-nightis very sluggish. With this change, performance is as good as ifrehype-starry-nightisn’t even used.Fix https://github.com/orgs/rehypejs/discussions/194