fix: exports field includes package.json #765
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remarkablemark
approved these changes
Jul 18, 2024
|
Releases:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the motivation for this pull request?
Many users have bundler issues with this package and the html-react-parser package that depends on it. Sometimes it is necessary to change how packages are resolved—for example, to force loading the server version in certain environments.
However, resolving the server version is difficult when importing the package.json is disabled by the package.json exports field. This patch enables code to import the package.json.
Beyond this bundling use case, I have found importing the package.json may be useful for reading versions, dependencies, and other metadata.
What is the current behavior?
An error is thrown if you try to import the package.json
What is the new behavior?
Importing the package.json is allowed
Checklist:
Thank you for reviewing!