Support design grid system #158
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template for Home Assistant / Lovelace Card Repository
Overview
Implements a method to compute the number of rows and columns used by the card. This should make it compatible with the new grid system.
Depending on the sections enabled in the card (title, sunset, moon phase, etc), it will use a different number of rows. These are some examples (the colored rows in the first column act as a guide):
Type of Change
Related Issues / Pull Requests
Fixes #145
Additional Details
I documented how to test the card in isolation and inside Home Assistant to README.md.
Thanks to @PhilippeP62 for doing 99% of the work in #145.