-
Notifications
You must be signed in to change notification settings - Fork 3
feat: kmod_tracker has allow/deny list #665
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR enhances the kernel module tracker plugin with configurable allow/deny lists and optional quiet logging. The plugin now supports fine-grained control over which kernel modules can load, addressing the need for more flexible module filtering beyond the default block-all behavior.
- Added allowlist/denylist configuration options for granular control over module loading
- Implemented quiet mode to reduce logging verbosity for targets with many modules
- Expanded comprehensive documentation with usage examples and configuration options
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
e0b90e7
to
f407f9b
Compare
I appreciate the PR! This looks good. On the technical points:
|
Also! This is our first external contribution. Which is very exciting. It also means that permissions have changed for our CI jobs so everything breaks for reasons that are not your fault. I am going to use this PR as a test to fix our actions. I will merge them separately ahead of your PR once they work. |
Cool 😎 thats exciting |
3adaff0
to
20be3fb
Compare
After the ci stuff is working lmk and ill rebase to address the comments. Off the cuff all my ideas are extremely hacky to handle |
c94ac56
to
f407f9b
Compare
f407f9b
to
761cd58
Compare
e07f763
to
1c12863
Compare
cb66cb5
to
c9eca26
Compare
@lockbox should be set on the CI issues. Thanks! |
c9eca26
to
0ebc681
Compare
088eeee
to
87fcae0
Compare
87fcae0
to
4861a70
Compare
FYSA: rebased this on main and ran tests |
Save for the init_module comments this should be gtg, did you want to solve that here or "eventually?" |
I can live with eventually on that. Merged. Thanks! |
this addresses #647 adding an allow / deny list. i added a denylist to allow for things like temporary masking etc of configs. not the most useful thing but its simple enough + has actually come in handy. feel free to tell me to nix it though.
i also added a "quiet" option which doesnt log to the console since some targets load hundreds of modules and it can get annoying trying to read output when driving manually
Closes #647