Skip to content

[bugfix] Use always | to join unique values in column aggregations except for --table-format=pretty #3471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 5, 2025
Merged

[bugfix] Use always | to join unique values in column aggregations except for --table-format=pretty #3471

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
17e17f5
Use always `|` to join unique values in column aggregations
vkarak Apr 29, 2025
568f3b2
Fix typo in local variable name
vkarak May 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 4 additions & 6 deletions reframe/frontend/reporting/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -646,13 +646,11 @@ def _group_testcases(testcases, groups, columns):
@time_function
def _aggregate_perf(grouped_testcases, aggr_fn, cols):
# Update delimiter for joining unique values based on the table format
table_foramt = runtime().get_option('general/0/table_format')
if table_foramt == 'csv':
delim = '|'
elif table_foramt == 'plain':
delim = ','
else:
table_format = runtime().get_option('general/0/table_format')
if table_format == 'pretty':
delim = '\n'
else:
delim = '|'

other_aggr = Aggregator.create('join_uniq', delim)
count_aggr = Aggregator.create('count')
Expand Down
Loading