Skip to content

[enhancement] Use ClusterShell to manipulate node lists instead of our own code #3470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 2, 2025

Conversation

vkarak
Copy link
Contributor

@vkarak vkarak commented Apr 29, 2025

Closes #3169.

@vkarak vkarak added this to the ReFrame 4.8.1 milestone Apr 29, 2025
@vkarak vkarak requested review from victorusu and teojgo April 29, 2025 14:59
@vkarak vkarak self-assigned this Apr 29, 2025
@vkarak vkarak changed the base branch from develop to master April 29, 2025 15:00
@vkarak vkarak force-pushed the refactor/use-clustershell-nodeset branch 2 times, most recently from 11c207d to e6f2ded Compare April 29, 2025 15:02
Copy link
Contributor

@teojgo teojgo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add ClusterShell to the doc requirements as well.

@github-project-automation github-project-automation bot moved this from Todo to In Progress in ReFrame Backlog Apr 29, 2025
@vkarak vkarak force-pushed the refactor/use-clustershell-nodeset branch from e6f2ded to f6e3d8b Compare April 29, 2025 17:11
@vkarak vkarak requested a review from ekouts April 30, 2025 13:42
@vkarak vkarak requested a review from teojgo April 30, 2025 14:28
@victorusu
Copy link
Contributor

This is great quality of life improvement. Now, I can also use it inside my ReFrame tests without having to create a virtual environment. Thanks!

Copy link
Contributor

@victorusu victorusu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@vkarak vkarak enabled auto-merge May 2, 2025 22:05
@vkarak vkarak merged commit 167ef86 into reframe-hpc:master May 2, 2025
37 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in ReFrame Backlog May 2, 2025
@vkarak vkarak deleted the refactor/use-clustershell-nodeset branch May 5, 2025 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Consider using ClusterShell.NodeSet for the manipulating Slurm nodelists
4 participants