[bugfix] Fix constraint evaluation for Slurm features starting with numbers #3448
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👎 this naively breaks any expression, will try fix. |
|
You can also try the unit tests locally by running |
yqshao
force-pushed
the
develop
branch
4 times, most recently
from
b91b06d to
4e6267d
Compare
|
I scratched the original idea of prefixing all symbols, as inserting the booleans directly seems easier if the symbols needs to be replaced anyway. PS: Sorry for the force-push spam (I intended to rebase & tidy the history). I think it's ready to be reviewed now. |
yqshao
changed the title
yqshao
changed the title
yqshao
changed the title
eval for Slurm features starting with numbers
Evaluating Slurm feature as symbols (with dash replaced) won't work for features like `8xT4` which are valid to Slurm. This commit directly inserts existence of Slurm features as booleans. `re.sub` should avoid potentially overlapping matches.
vkarak
reviewed
Apr 4, 2025
vkarak
requested changes
Apr 7, 2025
Co-authored-by: Vasileios Karakasis <vkarak@gmail.com>
|
Thanks! Committed the suggested changes. |
vkarak
approved these changes
Apr 7, 2025
vkarak
changed the title
eval for Slurm features starting with numbers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Features starting with a number (e.g.
4xA40) seem valid to slurm, but are not valid python identifiers. Currently this causes nodes getting filtered out when such feature is used as constraints.This prefixes all variables during eval with underscore to get around it.Edit: this now inserts boolean values directly into the constraints to support such Slurm features.