Skip to content

fix: stale values on form close while create and edit #6839

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

g-a-ankit
Copy link

@g-a-ankit g-a-ankit commented Jun 12, 2025

PR Checklist

Please check if your PR fulfills the following requirements:

Bugs / Features

What is the current behavior?

  • when "create" form
    • when user clicks on create form -> enters some value -> closes it
    • when he opens it again -> previous values are still in form
  • When edit
    • user clicks on editing item1 -> form opens and gets value from api -> user closes form
    • now user clicks on editing item2 -> from opens initially with stale values from past (i.e. item1 values)-> once api finishes item2 values are populated. this causes confusion for users with slow internet

What is the new behavior?

  • when "create" form

    • when user clicks on create form -> enters some value -> closes it
    • when he opens it again -> form is reset (no stale values from past)
  • When edit

    • user clicks on editing item1 -> form opens but fields are hidden until api req is complete (shows loading spinner)-> populates values once api completes. no stale value is displayed from past

fixes (issue)
#5954

Notes for reviewers

@g-a-ankit g-a-ankit requested a review from a team as a code owner June 12, 2025 09:32
Copy link

changeset-bot bot commented Jun 12, 2025

⚠️ No Changeset found

Latest commit: bbc2bc9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

netlify bot commented Jun 12, 2025

Deploy Preview for refine-doc-live-previews ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit bbc2bc9
🔍 Latest deploy log https://app.netlify.com/projects/refine-doc-live-previews/deploys/684a9ea55fc9a00008c0d3f9
😎 Deploy Preview https://deploy-preview-6839--refine-doc-live-previews.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant