fix(core): pass meta to useCan params #6826
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: bf1be72 The changes in this PR will be included in the next version bump. This PR includes changesets to release 29 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for refine-doc-live-previews ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
devarsh-mavani-19
force-pushed
the
devarsh/6802
branch
from
ad45f03 to
bf1be72
Compare
|
Hi @devarsh-mavani-19, thanks for the PR! Do you have time to add some tests? You can see the button tests here. |
alicanerdurmaz
requested changes
Jun 4, 2025
| @@ -43,7 +44,7 @@ export const useButtonCanAccess = ( | |||
| const { data: canAccess } = useCan({ | |||
| resource: props.resource?.name, | |||
| action: props.action === "clone" ? "create" : props.action, | |||
| params: { id: props.id, resource: props.resource }, | |||
| params: { ...props.meta, id: props.id, resource: props.resource }, | |||
There was a problem hiding this comment.
can we pass this like this:
Suggested change
| params: { ...props.meta, id: props.id, resource: props.resource }, | |
| params: { meta: { ...props.meta }, id: props.id, resource: props.resource }, |
I believe we can manage better with this way
BatuhanW
requested changes
Jun 5, 2025
| @@ -0,0 +1,7 @@ | |||
| --- | |||
| "@refinedev/core": major | |||
There was a problem hiding this comment.
Suggested change
| "@refinedev/core": major | |
| "@refinedev/core": patch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
Bugs / Features
[BUG] ShowButton does not pass meta params to useButtonCanAccess refine/inAntD #6802
What is the current behavior?
Currently it does not pass meta params to access control provider. Which limits the data that we may want to pass through useCan hook.
What is the new behavior?
Now it passes meta params through useCan hook
fixes (issue)
#6802
Notes for reviewers