Skip to content

feat: support edge-functions, identities, rpc, storage, access contro… #6751

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

sanchezcarlosjr
Copy link

…l, and authentication

PR Checklist

Please check if your PR fulfills the following requirements:

Bugs / Features

What is the current behavior?

What is the new behavior?

fixes (issue)

Notes for reviewers

@sanchezcarlosjr sanchezcarlosjr requested a review from a team as a code owner April 15, 2025 03:32
Copy link

changeset-bot bot commented Apr 15, 2025

🦋 Changeset detected

Latest commit: 82d3b8f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@refinedev/supabase Major
@refinedev/live-previews Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

netlify bot commented Apr 15, 2025

Deploy Preview for refine-doc-live-previews failed.

Built without sensitive environment variables

Name Link
🔨 Latest commit 82d3b8f
🔍 Latest deploy log https://app.netlify.com/sites/refine-doc-live-previews/deploys/6801e6e4a87fbd000819654f

@alicanerdurmaz
Copy link
Member

alicanerdurmaz commented Apr 18, 2025

Hello @sanchezcarlosjr

Thanks for your work! There are some nice ideas in the PR. But since it’s a bit large, could you please explain what problem or issue it’s solving? It would also be great if you could add a short explanation in the PR about what it fixes.

I have a couple of questions too:

  • Are the mock responses saved using Supabase, or did you write them by hand? I saw some differences between the mock data and the real data in the database. Maybe I made a mistake—if so, sorry!

  • accessControlProvider calling getIdentity from authProvider doesn’t seem very useful. Access control is usually more complex. Maybe this shouldn’t be part of the Supabase package. Did I miss something?

  • The rpcDataProvider and the regular dataProvider look very similar. Could they be merged?

Also, a small example app would be great!

Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants