fix: Include 'module' import condition in resolve.conditions #525
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change
Adds
module
import specifier to theresolve.conditions
for all three environments (ssr, worker, client).Context
ShadCN users were running into this issue:
TypeError: Cannot destructure property '__extends' of 'import_tslib.default' as it is undefined.
This appears to happen because:
node
import specifier to a wrapper that module that imports its cjs build, and reexports it as an esm via a default export (code)module
import specifier to an esm module (code)node
import condition to the worker and ssr import conditions, meaning it would resolve to tslibs esm wrapper around its cjs buildLinks