Add ability to enable/ disable SSR #522
Merged
+87
−21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying redwood-sdk-docs with
|
| Latest commit: |
ac8a605
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://79ed0b64.redwood-sdk-docs.pages.dev |
| Branch Preview URL: | https://pp-add-ssr-flag.redwood-sdk-docs.pages.dev |
peterp
commented
Jun 16, 2025
sdk/src/runtime/lib/router.ts
Outdated
Comment on lines
349
to
359
| * @param options.ssr - Disable sever side rendering for all these routes. This only allow client side rendering`, which requires `rscPayload` to be enabled. | ||
| */ | ||
| options: { | ||
| rscPayload: boolean; | ||
| } = { rscPayload: true }, | ||
| ssr: boolean; | ||
| } = { rscPayload: true, ssr: true }, | ||
| ): Route<T>[] { | ||
| const documentMiddleware: RouteMiddleware<T> = ({ rw }) => { | ||
| rw.Document = Document; | ||
| rw.rscPayload = options.rscPayload; | ||
| rw.ssr = options.ssr; |
peterp
commented
Jun 16, 2025
Comment on lines
+152
to
+171
| let html: ReadableStream<any>; | ||
|
|
||
| if (rw.ssr) { | ||
| html = await transformRscToHtmlStream({ | ||
| stream: rscPayloadStream1, | ||
| Document: rw.Document, | ||
| requestInfo: requestInfo, | ||
| }); | ||
| } else { | ||
| const emptyRscStream = renderToRscStream({ | ||
| node: React.createElement(React.Fragment, null, null), | ||
| actionResult: undefined, | ||
| onError, | ||
| }); | ||
| html = await transformRscToHtmlStream({ | ||
| stream: emptyRscStream, | ||
| Document: rw.Document, | ||
| requestInfo: requestInfo, | ||
| }); | ||
| } |
There was a problem hiding this comment.
Converts RSC to HTML or, not.
There was a problem hiding this comment.
Aaah, ok! So we return just the shell for that page, clever!
justinvdm
pushed a commit
that referenced
this pull request
Jun 16, 2025
This PR adds the ability to toggle server-side rendering.
```tsx
render(Document, [
// routes
], {
ssr: false,
rscPayload: true,
})
```
|
Fixes #515 |
|
@justinvdm I'm seeing a hydration error with this new flag in my test-repo. Is there something else I need to configure besides the flag on the route render? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the ability to toggle server-side rendering.