feat(sftp): added modtime metadata to sftp input #3358
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anthonyvitale
commented
Apr 22, 2025
| @@ -259,6 +267,11 @@ func (s *sftpReader) initScanner(ctx context.Context) (codec.DeprecatedFallbackS | |||
| return nil, service.ErrEndOfInput | |||
| } | |||
|
|
|||
| fileInfo, err := s.client.Stat(path) | |||
| if err != nil { | |||
| return nil, fmt.Errorf("stat path: %w", err) | |||
There was a problem hiding this comment.
Wasn't really sure what kind of error checking we wanted, went with this as a default, let me know what's best.
anthonyvitale
force-pushed
the
feat/sftp-in-modtime-metadata
branch
from
ebae68a to
0a230fb
Compare
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #2955, #2970
Adds modTime to sftp input metadata