-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Add Redis readiness verification (#3555) #3596
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Add Redis readiness verification (#3555) #3596
Conversation
Hi @ManelCoutinhoSensei, thank you for your contribution! We’ll review your change soon. |
@petyaslavova you need to rerun the failed tests due to the test suit flakiness |
Hi @petyaslavova , any news about this one? |
Hi @ManelCoutinhoSensei, I have started the review, but couldn't complete it. |
Should I solve the conflicts because the PR reviews are going to be done this week or should I postpone it? |
Hi @ManelCoutinhoSensei, please wait for a while with the conflict solving. We first need to address one more planned change related to the async cluster, and then I will be able to progress on this PR. |
Hey @petyaslavova! 🙌 Just checking in to see if there are any updates or an estimated timeline for moving forward with this PR. Totally understand things can get busy — just wanted to make sure it’s still on your radar. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @ManelCoutinhoSensei,
Apologies for the delay in reviewing the PR. I've added some comments and suggestions for changes that I believe will help make the code more maintainable in the long term. While the comments are placed in the sync client/connection code, they apply to the async parts as well.
96db4ac
to
393563a
Compare
393563a
to
3ee1832
Compare
3ee1832
to
416f18f
Compare
Pull Request check-list
Please make sure to review and check all of these items:
NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.
Description of change
Fixes #3555 (specially the comment on that issue)
Please check if you'd rather run the tests with
check_ready=True
by default (I also tested that) and if you think that any other tests deserve a second version with this flag set.