Skip to content

Add a test to verify failover on DNS unresolvable host error #4182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Add a test to verify failover on DNS unresolvable host error #4182

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
75e6b05
Add a test to verify failover on DNS unresolvable host error
ggivo Jun 18, 2025
6c7bc28
formating
ggivo Jun 18, 2025
a4e0bf9
address review comments
ggivo Jun 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
72 changes: 60 additions & 12 deletions src/test/java/redis/clients/jedis/misc/AutomaticFailoverTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
package redis.clients.jedis.misc;

import java.net.UnknownHostException;
import java.util.Arrays;
import java.util.Collections;
import java.util.List;
Expand All @@ -18,8 +19,11 @@
import redis.clients.jedis.providers.MultiClusterPooledConnectionProvider;
import redis.clients.jedis.util.IOUtils;

import static org.hamcrest.MatcherAssert.assertThat;
import static org.hamcrest.Matchers.instanceOf;
import static org.junit.jupiter.api.Assertions.assertEquals;
import static org.junit.jupiter.api.Assertions.assertFalse;
import static org.junit.jupiter.api.Assertions.assertThrows;
import static org.junit.jupiter.api.Assertions.assertTrue;

public class AutomaticFailoverTest {
Expand Down Expand Up @@ -87,18 +91,59 @@ public void transactionWithSwitch() {
assertEquals("bar", jedis2.hget("thash", "foo"));
}

@Test
public void commandFailoverUnresolvableHost() {
int slidingWindowMinCalls = 2;
int slidingWindowSize = 2;

HostAndPort unresolvableHostAndPort = new HostAndPort("unresolvable", 6379);
MultiClusterClientConfig.Builder builder = new MultiClusterClientConfig.Builder(
getClusterConfigs(clientConfig, unresolvableHostAndPort,
workingEndpoint.getHostAndPort())).retryWaitDuration(1).retryMaxAttempts(1)
.circuitBreakerSlidingWindowMinCalls(slidingWindowMinCalls)
.circuitBreakerSlidingWindowSize(slidingWindowSize);

RedisFailoverReporter failoverReporter = new RedisFailoverReporter();
MultiClusterPooledConnectionProvider cacheProvider = new MultiClusterPooledConnectionProvider(
builder.build());
cacheProvider.setClusterFailoverPostProcessor(failoverReporter);

UnifiedJedis jedis = new UnifiedJedis(cacheProvider);

String key = "hash-" + System.nanoTime();
log.info("Starting calls to Redis");
assertFalse(failoverReporter.failedOver);

for (int attempt = 0; attempt < slidingWindowMinCalls; attempt++) {
Throwable thrown = assertThrows(JedisConnectionException.class,
() -> jedis.hset(key, "f1", "v1"));
assertThat(thrown.getCause(), instanceOf(UnknownHostException.class));
assertFalse(failoverReporter.failedOver);
}

// should failover now
jedis.hset(key, "f1", "v1");
assertTrue(failoverReporter.failedOver);

assertEquals(Collections.singletonMap("f1", "v1"), jedis.hgetAll(key));
jedis.flushAll();

jedis.close();
}

@Test
public void commandFailover() {
int slidingWindowMinCalls = 10;
int slidingWindowSize = 10;

MultiClusterClientConfig.Builder builder = new MultiClusterClientConfig.Builder(
getClusterConfigs(clientConfig, hostPortWithFailure, workingEndpoint.getHostAndPort()))
.circuitBreakerSlidingWindowMinCalls(slidingWindowMinCalls)
.circuitBreakerSlidingWindowSize(slidingWindowSize);
.retryWaitDuration(1).circuitBreakerSlidingWindowMinCalls(slidingWindowMinCalls)
.circuitBreakerSlidingWindowSize(slidingWindowSize);

RedisFailoverReporter failoverReporter = new RedisFailoverReporter();
MultiClusterPooledConnectionProvider cacheProvider = new MultiClusterPooledConnectionProvider(builder.build());
MultiClusterPooledConnectionProvider cacheProvider = new MultiClusterPooledConnectionProvider(
builder.build());
cacheProvider.setClusterFailoverPostProcessor(failoverReporter);

UnifiedJedis jedis = new UnifiedJedis(cacheProvider);
Expand Down Expand Up @@ -132,12 +177,13 @@ public void pipelineFailover() {

MultiClusterClientConfig.Builder builder = new MultiClusterClientConfig.Builder(
getClusterConfigs(clientConfig, hostPortWithFailure, workingEndpoint.getHostAndPort()))
.circuitBreakerSlidingWindowMinCalls(slidingWindowMinCalls)
.circuitBreakerSlidingWindowSize(slidingWindowSize)
.fallbackExceptionList(Collections.singletonList(JedisConnectionException.class));
.circuitBreakerSlidingWindowMinCalls(slidingWindowMinCalls)
.circuitBreakerSlidingWindowSize(slidingWindowSize)
.fallbackExceptionList(Collections.singletonList(JedisConnectionException.class));

RedisFailoverReporter failoverReporter = new RedisFailoverReporter();
MultiClusterPooledConnectionProvider cacheProvider = new MultiClusterPooledConnectionProvider(builder.build());
MultiClusterPooledConnectionProvider cacheProvider = new MultiClusterPooledConnectionProvider(
builder.build());
cacheProvider.setClusterFailoverPostProcessor(failoverReporter);

UnifiedJedis jedis = new UnifiedJedis(cacheProvider);
Expand All @@ -164,13 +210,15 @@ public void failoverFromAuthError() {
int slidingWindowSize = 10;

MultiClusterClientConfig.Builder builder = new MultiClusterClientConfig.Builder(
getClusterConfigs(clientConfig, endpointForAuthFailure.getHostAndPort(), workingEndpoint.getHostAndPort()))
.circuitBreakerSlidingWindowMinCalls(slidingWindowMinCalls)
.circuitBreakerSlidingWindowSize(slidingWindowSize)
.fallbackExceptionList(Collections.singletonList(JedisAccessControlException.class));
getClusterConfigs(clientConfig, endpointForAuthFailure.getHostAndPort(),
workingEndpoint.getHostAndPort()))
.circuitBreakerSlidingWindowMinCalls(slidingWindowMinCalls)
.circuitBreakerSlidingWindowSize(slidingWindowSize)
.fallbackExceptionList(Collections.singletonList(JedisAccessControlException.class));

RedisFailoverReporter failoverReporter = new RedisFailoverReporter();
MultiClusterPooledConnectionProvider cacheProvider = new MultiClusterPooledConnectionProvider(builder.build());
MultiClusterPooledConnectionProvider cacheProvider = new MultiClusterPooledConnectionProvider(
builder.build());
cacheProvider.setClusterFailoverPostProcessor(failoverReporter);

UnifiedJedis jedis = new UnifiedJedis(cacheProvider);
Expand Down
Loading