Skip to content

Fix failing ModuleTest & test against 8.0-RC1-pre #4131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 7, 2025

Conversation

ggivo
Copy link
Collaborator

@ggivo ggivo commented Apr 3, 2025

Fix failing ModuleTest.java

The vector-sets module is a part of Redis Core and is available by default with commit redis/redis@78e0d87

Module test was expecting there are no other modules loaded on the bare Redis server which is no longer the case.
Update the test to check explicitly for loading/unloading of the test module

Fix SearchWithParamsTest
After bump to 8.0-RC1 error message got changed,

@ggivo ggivo requested a review from atakavci April 7, 2025 06:20
@ggivo ggivo changed the title Test against 8.0-RC1-pre Fix failing ModuleTest & test against 8.0-RC1-pre Apr 7, 2025
@ggivo ggivo added maintenance testing skip-changelog Ignore pull request from release note labels Apr 7, 2025
@ggivo ggivo requested a review from tishun April 7, 2025 06:30
Copy link
Contributor

@atakavci atakavci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ggivo ggivo closed this Apr 7, 2025
@ggivo ggivo reopened this Apr 7, 2025
@ggivo ggivo merged commit 856a3b0 into redis:master Apr 7, 2025
15 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance skip-changelog Ignore pull request from release note testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants