test: refactor TestBasicCredentials using table-driven tests #3406
+84
−29
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR refactors the
TestBasicCredentials
function to use a table-driven testing approach. The goal is to improve test clarity, reduce duplication, and make it easier to extend with new cases in the future.Changes
TestBasicCredentials
to table-driven formatt.Fatalf
witht.Errorf
to allow multiple assertion failures per test runMotivation
Table-driven tests are idiomatic in Go and make it easier to:
Notes
Also included additional edge cases such as: