Skip to content

fix: move response status check before parsing JSON #451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 5, 2025
Merged

fix: move response status check before parsing JSON #451

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/badfish/main.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -477,15 +477,16 @@ async def get_host_type(self, _interfaces_path):

async def find_session_uri(self):
_response = await self.get_request(self.root_uri, _get_token=True)
raw = await _response.text("utf-8", "ignore")
data = json.loads(raw.strip())

status = _response.status
if status == 401:
raise BadfishException(f"Failed to authenticate. Verify your credentials for {self.host}")
if status not in [200, 201]:
raise BadfishException(f"Failed to communicate with {self.host}")

raw = await _response.text("utf-8", "ignore")
data = json.loads(raw.strip())

redfish_version = int(data["RedfishVersion"].replace(".", ""))
session_uri = None
if redfish_version >= 160:
Expand Down
Loading