Skip to content

[GH#527]: Additional Resources KB links #528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

bredamc
Copy link
Contributor

@bredamc bredamc commented Jul 3, 2025

Issue:
#527

Additional information:
Updates KB links in Additional Resources section, for compliance with DITA.

@bredamc bredamc marked this pull request as draft July 3, 2025 13:13
@bergerhoffer
Copy link
Collaborator

@bredamc @mmuehlfeldRH -

@jeana-redhat brought up a good point when asking me about a similar item. We should just double check with the ToolX team before updating this guidance to make sure there are no issues. I hadn't even thought about it, but Jeana mentioned about checking if there were any restrictions on link text length in additional resources sections. So we should just double check with someone before updating this guidance.

After we check that it's fine, then I +1 this change.

@bergerhoffer bergerhoffer added the Style guideline Topics that add or modify style guidelines label Jul 9, 2025
@jeana-redhat
Copy link

@bredamc @mmuehlfeldRH -

@jeana-redhat brought up a good point when asking me about a similar item. We should just double check with the ToolX team before updating this guidance to make sure there are no issues. I hadn't even thought about it, but Jeana mentioned about checking if there were any restrictions on link text length in additional resources sections. So we should just double check with someone before updating this guidance.

After we check that it's fine, then I +1 this change.

NB: I am drafting a Q about this and linking to this PR 🤓

@bredamc
Copy link
Contributor Author

bredamc commented Jul 9, 2025

Thank you, @jeana-redhat and @bergerhoffer!

We also need to update the man pages section, but I didn't get a chance to do that yet.

@neal-timpe
Copy link

LGTM

@@ -60,7 +60,7 @@ The meaning of content relies on the order in which you present it. For example,

.Additional resources

* Understanding WCAG 2.0
* link:https://www.w3.org/TR/UNDERSTANDING-WCAG20/Overview.html[Understanding WCAG 2.0]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As long as this is okay to have second level bullets, this LGTM!

@bergerhoffer
Copy link
Collaborator

Thank you, @jeana-redhat and @bergerhoffer!

We also need to update the man pages section, but I didn't get a chance to do that yet.

I think that is fine to do in a separate PR. That might take a little more thought

@bredamc bredamc marked this pull request as ready for review July 11, 2025 10:34
Copy link
Contributor

@lahinson lahinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@ndeevy ndeevy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM too!

@bredamc bredamc merged commit 8e035f1 into redhat-documentation:main Jul 14, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Style guideline Topics that add or modify style guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants