fix(sandbox): update welcome message and fix trial duration #716
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 2, 2025 12:15
mfrancisc
requested review from
Lucifergene,
rohitkrai03,
karthikjeeyar and
alexeykazakov
as code owners
Missing ChangesetsThe following package(s) are changed by this PR but do not have a changeset:
See CONTRIBUTING.md for more information about how to add changesets. Changed Packages
|
mfrancisc
changed the title
alexeykazakov
approved these changes
May 2, 2025
Lucifergene
requested changes
May 5, 2025
There was a problem hiding this comment.
Thanks for this PR @mfrancisc
Have added some comments. PTAL :)
workspaces/sandbox/plugins/sandbox/src/components/SandboxCatalog/SandboxCatalogBanner.tsx
Outdated
Show resolved
Hide resolved
workspaces/sandbox/plugins/sandbox/src/components/SandboxCatalog/SandboxCatalogBanner.tsx
Outdated
Show resolved
Hide resolved
workspaces/sandbox/plugins/sandbox/src/components/SandboxCatalog/SandboxCatalogBanner.tsx
Outdated
Show resolved
Hide resolved
…og/SandboxCatalogBanner.tsx Co-authored-by: Avik Kundu <avikkundu8d@gmail.com>
…og/SandboxCatalogBanner.tsx Co-authored-by: Avik Kundu <avikkundu8d@gmail.com>
Lucifergene
approved these changes
May 5, 2025
|
Looks like the tests are failing: https://github.com/redhat-developer/rhdh-plugins/actions/runs/14834610589/job/41643123310?pr=716 Can u check once? |
Lucifergene
reviewed
May 5, 2025
workspaces/sandbox/plugins/sandbox/src/components/SandboxCatalog/SandboxCatalogBanner.tsx
Outdated
Show resolved
Hide resolved
…og/SandboxCatalogBanner.tsx Co-authored-by: Avik Kundu <avikkundu8d@gmail.com>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey, I just made a Pull Request!
givenNameorcompliantUsernameendDateprovided by the backend , and not fixed to 30 days. Some users might have more than 30 days. Also the last day is excluded. The current logic was counting 31 days.endDateis not setDepends on: codeready-toolchain/registration-service#529
Jiras: