Skip to content

fix: have service selectors match templates, too (#882) #899

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 13, 2025

Conversation

adietish
Copy link
Collaborator

@adietish adietish commented Jun 11, 2025

fixes #882

@adietish adietish marked this pull request as draft June 11, 2025 12:39
@adietish adietish self-assigned this Jun 11, 2025
@adietish adietish requested a review from sbouchet June 11, 2025 17:54
@adietish adietish moved this to 👀 In review in IDE Cloudaptors Jun 11, 2025
@adietish adietish marked this pull request as ready for review June 11, 2025 17:55
Signed-off-by: Andre Dietisheim <adietish@redhat.com>
Copy link

@adietish adietish changed the title fix: have service selectors match templates, too (#859) fix: have service selectors match templates, too (#882) Jun 12, 2025
Copy link
Collaborator

@sbouchet sbouchet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. can verify that CronJob YAML with labels is correclty displaying matching elements

@adietish adietish merged commit 5cbef16 into redhat-developer:main Jun 13, 2025
10 checks passed
@adietish adietish deleted the issue-859 branch June 13, 2025 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

editor: Service selector should report matching labels in Deployment template
2 participants