Skip to content

fix: provide unauthorized error msg if ex is unauthorized (#771) #772

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 23, 2024
Merged

fix: provide unauthorized error msg if ex is unauthorized (#771) #772

merged 1 commit into from
Jul 23, 2024

Conversation

adietish
Copy link
Collaborator

fixes #771

@adietish adietish self-assigned this Jul 16, 2024
@adietish adietish requested a review from sbouchet July 16, 2024 16:08
@sbouchet
Copy link
Collaborator

@adietish : please fix compilation errors :
file:///home/runner/work/intellij-kubernetes/intellij-kubernetes/src/main/kotlin/com/redhat/devtools/intellij/kubernetes/tree/ResourceTreeToolWindowFactory.kt:27:51 Unresolved reference: PopupHandlerAdapter

@adietish
Copy link
Collaborator Author

adietish commented Jul 19, 2024 •
edited
Loading

@adietish : please fix compilation errors : file:///home/runner/work/intellij-kubernetes/intellij-kubernetes/src/main/kotlin/com/redhat/devtools/intellij/kubernetes/tree/ResourceTreeToolWindowFactory.kt:27:51 Unresolved reference: PopupHandlerAdapter

🤦, the import was still there. IntelliJ didn't error on it.
Thanks for pointing out.

@adietish
fix: provide unauthorized error msg if ex is unauthorized (redhat-dev…
77c1f9c 
…eloper#771)

Signed-off-by: Andre Dietisheim <adietish@redhat.com>
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

sbouchet
sbouchet approved these changes Jul 23, 2024
View reviewed changes
Copy link
Collaborator

@sbouchet sbouchet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

message is now consistent with cluster status. LGTM

@adietish adietish merged commit c84158e into redhat-developer:main Jul 23, 2024
12 checks passed
@adietish adietish deleted the issue-771 branch July 23, 2024 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbouchet sbouchet sbouchet approved these changes

Assignees

@adietish adietish

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unhelpful error if I try to push editor to a cluster where I am not authorized (ex. token expired)
2 participants
@adietish @sbouchet