Skip to content

fix: Address shellcheck warnings #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

olivergondza
Copy link

/kind failing-test

What does this PR do / why we need it:

The test is fixing the shellcheck warnings in the script.

Have you updated the necessary documentation?

  • [no] Documentation update is required by this PR.
  • [n/a] Documentation has been updated.

Which issue(s) this PR fixes:

None

Test acceptance criteria:

  • [n/a] Unit Test
  • [n/a] E2E Test

How to test changes / Special notes to the reviewer:

Copy link

openshift-ci bot commented May 19, 2025

@olivergondza: The label(s) kind/failing-test cannot be applied, because the repository doesn't have them.

In response to this:

/kind failing-test

What does this PR do / why we need it:

The test is fixing the shellcheck warnings in the script.

Have you updated the necessary documentation?

  • [no] Documentation update is required by this PR.
  • [n/a] Documentation has been updated.

Which issue(s) this PR fixes:

None

Test acceptance criteria:

  • [n/a] Unit Test
  • [n/a] E2E Test

How to test changes / Special notes to the reviewer:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci openshift-ci bot requested review from varshab1210 and wtam2018 May 19, 2025 13:40
Signed-off-by: Oliver Gondža <ogondza@gmail.com>
@svghadi
Copy link
Member

svghadi commented May 19, 2025

/ok-to-test

Signed-off-by: Oliver Gondža <ogondza@gmail.com>
@olivergondza
Copy link
Author

@svghadi, can you please take a look? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants