This repository was archived by the owner on Mar 24, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 180
Add rediscluster support #573
Merged
Merged
Changes from 1 commit
Commits
Show all changes
28 commits
Select commit
Hold shift + click to select a range
7492d69
Add redisc cluster client support
e9b646a
Add integration tests for ClusterRedisClient
6050bc3
remove unused import
8d5d40b
remove unnneeded comment
cb95feb
remove unused import
9655d17
disable pylint warning
6214d10
Update baseplate/clients/redis.py
FranGM 78dc569
Update baseplate/clients/redis.py
FranGM 1765def
address comments
ffdecf9
set version
9570abf
Update baseplate/clients/redis_cluster.py
FranGM df35f03
address comments (take 2)
94914ae
When read_from_replicas is enabled also read from master
191ed5d
Return only one node on get_node_by_slot
FranGM c78dcf2
fix documentation lint issues
FranGM 8db95aa
change some client defaults
FranGM 024adff
add more tests
FranGM b904a82
Remove unused metric
aeb416d
pass read_from_replicas arg when creating pipeline
FranGM 2c099df
bump redis-py-cluster version
FranGM 1ee4bdc
Add hot key tracker to the cluster reddis client
35839ad
Merge branch 'rediscluster-support' of github.com:FranGM/baseplate.py…
4255cf2
Allow to configure max_connections_per_node
FranGM 972f82d
Update to current redis-py-cluster version
FranGM 96054f4
Update requirements-transitive.txt
FranGM c35f976
Add hot key tracking to docs
44ecda5
Update setup.py
FranGM 99b4ffd
Update docs/api/baseplate/clients/redis_cluster.rst
spladug File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does this not return all of them rather than just the primary?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah yes, and I'm very annoyed at myself for not having added a test for that method. I'll fix it and look at adding a test.