Add Command-graph class section #4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add command-graph class section to spec draft. - Align some node section ids to use "khr-graph-*" - Changes to better align with SYCL spec style: - Condense overloaded functions into single section where appropriate - Reorder constraints, effects etc to match current spec style - Align exception language. - Include property defs in class header. - Add table describing graph states. - Editorial changes: - Minor wording changes where I felt we were referring to specific implementation behavior. - Minor rewrites to execution and finalization descriptions for increased clarity.
Bensuo
commented
Jun 3, 2025
reble
reviewed
Jun 3, 2025
AerialMantis
reviewed
Jun 5, 2025
- Minor wording changes to descriptions - Condense some overload descriptions - Add non-normative note in command-graph description
EwanC
reviewed
Jun 9, 2025
Bensuo
commented
Jun 10, 2025
EwanC
reviewed
Jun 10, 2025
This was referenced Jun 23, 2025
reble
approved these changes
Jun 26, 2025
- Remove properties from command_graph.h - Inline definition into properties section - Switch from table to API definitions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.