Patch 2 Updated with Custom Image Component

[krunalbad]

No description provided.

[DaniAkash]

@krunalbad React Native Fast Image has too many issues which is why I didn't add it to the package. May be we can think of a different approach to allow people use their own image components?

[krunalbad]

Yeah we can try that approach! Great suggestion!

[krunalbad]

Added possible feature! Please review!

[DaniAkash]

Thanks @krunalbad
Now that we are allowing custom components, we need to also ensure prop types are properly displayed based on the component

[krunalbad]

What are you suggesting? @DaniAkash

[krunalbad]

I have tested it on multiple devices of both platforms so far it worked great. One another feature we can add is onLayout as it common for most of the 3rd pkgs out there and even for Image. Let me know your concern. It will help much better in application development!

[DaniAkash]

I have tested it on multiple devices of both platforms so far it worked great. One another feature we can add is onLayout as it common for most of the 3rd pkgs out there and even for Image. Let me know your concern. It will help much better in application development!

BetterImage extends all the props of regualar image component including onLayout. This should work out of the box

[DaniAkash]

What are you suggesting? @DaniAkash

Try if you can infer prop types based on the component using typescript

[krunalbad]

I have tested it on multiple devices of both platforms so far it worked great. One another feature we can add is onLayout as it common for most of the 3rd pkgs out there and even for Image. Let me know your concern. It will help much better in application development!

BetterImage extends all the props of regualar image component including onLayout. This should work out of the box

Yeah I noticed! Great!
Most of the pkgs have this onLayout common.
As there are already otherProps sent to it, so it should work for all quite good.

[krunalbad]

What are you suggesting? @DaniAkash

Try if you can infer prop types based on the component using typescript

Sure I'll look into it!

[krunalbad]

@DaniAkash Am I missing something here?

[krunalbad]

Are you suggesting this change? @DaniAkash
From imageComponent?: Component; to imageComponent?: ReactElement;
or is it something else ? let me know what am i missing here!