Split into smaller blocks if the order of block size is larger than max order #35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jiegec
reviewed
Sep 21, 2024
src/lib.rs
Outdated
|
|
||
| // If the order of size is larger than the max order, | ||
| // split it into smaller blocks. | ||
| if size.trailing_zeros() as usize > (ORDER - 1) { |
There was a problem hiding this comment.
I think comparing size and 2^ORDER is easier and faster here?
There was a problem hiding this comment.
Since trailing_zeros calculation is calculated again when adding a block to free_list, I think we can calculate it first for comparison, if the block needs to be split, just simply assign it as the maximum ORDER, I think this should be faster. (I've forced-push this change)
bigsaltyfishes
force-pushed
the
master
branch
from
2f8e0cf to
caa5a2e
Compare
…ax order Signed-off-by: bigsaltyfishes <bigsaltyfishes@gmail.com>
bigsaltyfishes
force-pushed
the
master
branch
from
caa5a2e to
95ed662
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.