Skip to content

Conversation

@rcoh
Copy link
Owner

@rcoh rcoh commented Apr 24, 2025

No description provided.

@rcoh rcoh requested a review from Copilot April 24, 2025 23:19
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces support for aliases in pipelines by refactoring how alias definitions are loaded, parsed, and propagated across various modules. Key changes include:

  • Integrating an AliasCollection type and updating QueryContainer to include aliases.
  • Modifying diff hunks in parsing (src/lang.rs), error reporting (src/errors.rs), and alias handling (src/alias.rs).
  • Bumping dependency versions and updating integration tests and documentation to reflect alias usage.

Reviewed Changes

Copilot reviewed 14 out of 14 changed files in this pull request and generated no comments.

Show a summary per file
File Description
tests/integration.rs Adds the AliasCollection import and updates QueryContainer instantiation; adds a "--no-alias" flag.
tests/code_blocks.rs Updates code block extraction to use the new pulldown_cmark TagEnd syntax.
src/operator/min.rs Uses f64::INFINITY instead of std::f64::INFINITY.
src/operator/max.rs Uses f64::NEG_INFINITY instead of std::f64::NEG_INFINITY.
src/lib.rs Exposes the alias module and updates QueryContainer’s lifetime signature.
src/lang.rs Adjusts Span type and refactors parse_operators to incorporate AliasCollection properly.
src/errors.rs Updates QueryContainer to store aliases and adjusts associated lifetime annotations.
src/data.rs Simplifies duration subtraction using the -= operator.
src/alias.rs Reworks alias parsing to use Cow for alias storage and introduces improved error handling.
benches/e2e.rs Updates QueryContainer instantiation to use the new alias support.
README.md Updates documentation to describe the alias feature and file format.
Cargo.toml Bumps several dependencies to newer versions.

@rcoh rcoh enabled auto-merge (squash) April 24, 2025 23:20
@rcoh rcoh merged commit f1f5619 into main Apr 24, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant