Skip to content

[data] fix working code snippets #52748

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
May 6, 2025
Merged

[data] fix working code snippets #52748

merged 6 commits into from
May 6, 2025

Conversation

iamjustinhsu
Copy link
Collaborator

Why are these changes needed?

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@iamjustinhsu
fix working code snippets
8657cdc 
Signed-off-by: jhsu <jhsu@anyscale.com>
@iamjustinhsu iamjustinhsu requested a review from a team as a code owner May 2, 2025 18:27
@iamjustinhsu
use ...
d85651e 
Signed-off-by: jhsu <jhsu@anyscale.com>
@omatthew98 omatthew98 added the go add ONLY when ready to merge, run all tests label May 2, 2025
@raulchen raulchen enabled auto-merge (squash) May 2, 2025 18:32
@iamjustinhsu
fix inspecting data rst
4339948 
Signed-off-by: jhsu <jhsu@anyscale.com>
@iamjustinhsu iamjustinhsu removed the go add ONLY when ready to merge, run all tests label May 2, 2025
@iamjustinhsu iamjustinhsu requested a review from a team as a code owner May 2, 2025 19:52
@github-actions github-actions bot disabled auto-merge May 2, 2025 19:52
iamjustinhsu and others added 2 commits May 2, 2025 13:07
@iamjustinhsu
Merge branch 'master' of github.com:ray-project/ray into jhsu/fix-doc
5f251d2 
Signed-off-by: jhsu <jhsu@anyscale.com>
@iamjustinhsu
[Data] Speed up printing the schema (#52612)
87181da 
<!-- Thank you for your contribution! Please review
https://github.com/ray-project/ray/blob/master/CONTRIBUTING.rst before
opening a pull request. -->

<!-- Please add a reviewer to the assignee section when you create a PR.
If you don't have the access to it, we will shortly find a reviewer and
assign them to your PR. -->

## Why are these changes needed?
if the dataset only has read functions applied, due to lazy execution
model, we need to perform computation to read the schema. This PR
removes the special case if the schema is not present.
<!-- Please give a short summary of the change and the problem this
solves. -->

## Related issue number

<!-- For example: "Closes #1234" -->
#50361

## Checks

- [ ] I've signed off every commit(by using the -s flag, i.e., `git
commit -s`) in this PR.
- [x] I've run `scripts/format.sh` to lint the changes in this PR.
- [ ] I've included any doc changes needed for
https://docs.ray.io/en/master/.
- [ ] I've added any new APIs to the API Reference. For example, if I
added a
method in Tune, I've added it in `doc/source/tune/api/` under the
           corresponding `.rst` file.
- [ ] I've made sure the tests are passing. Note that there might be a
few flaky tests, see the recent failures at https://flakey-tests.ray.io/
- Testing Strategy
   - [ ] Unit tests
   - [ ] Release tests
   - [ ] This PR is not tested :(

---------

Signed-off-by: jhsu <jhsu@anyscale.com>
@iamjustinhsu iamjustinhsu changed the title fix working code snippets [data] fix working code snippets May 3, 2025
crypdick
crypdick approved these changes May 5, 2025
View reviewed changes
Copy link
Contributor

@crypdick crypdick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

stamp

@iamjustinhsu iamjustinhsu added the go add ONLY when ready to merge, run all tests label May 5, 2025
@bveeramani bveeramani merged commit 075d86e into master May 6, 2025
6 checks passed
@bveeramani bveeramani deleted the jhsu/fix-doc branch May 6, 2025 17:35
vickytsang pushed a commit to ROCm/ray that referenced this pull request May 6, 2025
@iamjustinhsu
[data] fix working code snippets (ray-project#52748)
5dfc2b0 
<!-- Thank you for your contribution! Please review
https://github.com/ray-project/ray/blob/master/CONTRIBUTING.rst before
opening a pull request. -->

<!-- Please add a reviewer to the assignee section when you create a PR.
If you don't have the access to it, we will shortly find a reviewer and
assign them to your PR. -->

## Why are these changes needed?

<!-- Please give a short summary of the change and the problem this
solves. -->

## Related issue number

<!-- For example: "Closes ray-project#1234" -->

## Checks

- [ ] I've signed off every commit(by using the -s flag, i.e., `git
commit -s`) in this PR.
- [ ] I've run `scripts/format.sh` to lint the changes in this PR.
- [ ] I've included any doc changes needed for
https://docs.ray.io/en/master/.
- [ ] I've added any new APIs to the API Reference. For example, if I
added a
method in Tune, I've added it in `doc/source/tune/api/` under the
           corresponding `.rst` file.
- [ ] I've made sure the tests are passing. Note that there might be a
few flaky tests, see the recent failures at https://flakey-tests.ray.io/
- Testing Strategy
   - [ ] Unit tests
   - [ ] Release tests
   - [ ] This PR is not tested :(

---------

Signed-off-by: jhsu <jhsu@anyscale.com>
GokuMohandas pushed a commit that referenced this pull request May 8, 2025
@iamjustinhsu @GokuMohandas
[data] fix working code snippets (#52748)
7655ca7 
<!-- Thank you for your contribution! Please review
https://github.com/ray-project/ray/blob/master/CONTRIBUTING.rst before
opening a pull request. -->

<!-- Please add a reviewer to the assignee section when you create a PR.
If you don't have the access to it, we will shortly find a reviewer and
assign them to your PR. -->

## Why are these changes needed?

<!-- Please give a short summary of the change and the problem this
solves. -->

## Related issue number

<!-- For example: "Closes #1234" -->

## Checks

- [ ] I've signed off every commit(by using the -s flag, i.e., `git
commit -s`) in this PR.
- [ ] I've run `scripts/format.sh` to lint the changes in this PR.
- [ ] I've included any doc changes needed for
https://docs.ray.io/en/master/.
- [ ] I've added any new APIs to the API Reference. For example, if I
added a
method in Tune, I've added it in `doc/source/tune/api/` under the
           corresponding `.rst` file.
- [ ] I've made sure the tests are passing. Note that there might be a
few flaky tests, see the recent failures at https://flakey-tests.ray.io/
- Testing Strategy
   - [ ] Unit tests
   - [ ] Release tests
   - [ ] This PR is not tested :(

---------

Signed-off-by: jhsu <jhsu@anyscale.com>
zhaoch23 pushed a commit to Bye-legumes/ray that referenced this pull request May 14, 2025
@iamjustinhsu @zhaoch23
[data] fix working code snippets (ray-project#52748)
f7718fc 
<!-- Thank you for your contribution! Please review
https://github.com/ray-project/ray/blob/master/CONTRIBUTING.rst before
opening a pull request. -->

<!-- Please add a reviewer to the assignee section when you create a PR.
If you don't have the access to it, we will shortly find a reviewer and
assign them to your PR. -->

## Why are these changes needed?

<!-- Please give a short summary of the change and the problem this
solves. -->

## Related issue number

<!-- For example: "Closes ray-project#1234" -->

## Checks

- [ ] I've signed off every commit(by using the -s flag, i.e., `git
commit -s`) in this PR.
- [ ] I've run `scripts/format.sh` to lint the changes in this PR.
- [ ] I've included any doc changes needed for
https://docs.ray.io/en/master/.
- [ ] I've added any new APIs to the API Reference. For example, if I
added a
method in Tune, I've added it in `doc/source/tune/api/` under the
           corresponding `.rst` file.
- [ ] I've made sure the tests are passing. Note that there might be a
few flaky tests, see the recent failures at https://flakey-tests.ray.io/
- Testing Strategy
   - [ ] Unit tests
   - [ ] Release tests
   - [ ] This PR is not tested :(

---------

Signed-off-by: jhsu <jhsu@anyscale.com>
Signed-off-by: zhaoch23 <c233zhao@uwaterloo.ca>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raulchen raulchen raulchen approved these changes

@crypdick crypdick crypdick approved these changes

@omatthew98 omatthew98 omatthew98 approved these changes

Assignees
No one assigned
Labels
go add ONLY when ready to merge, run all tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@iamjustinhsu @raulchen @crypdick @omatthew98 @bveeramani