Skip to content

[llm][test] Use smolVLM in unit tests #51856

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 31, 2025

Conversation

lk-chen
Copy link
Contributor

@lk-chen lk-chen commented Mar 31, 2025

Why are these changes needed?

While bumping vLLM to 0.8.2, test_vision_model is failing because:

  • the previously used llava-354m model was random generated
  • during test, multi_modal_projector(..) returns [[nan, nan, ...]...]
  • this line introduced in vLLM 0.8.* does not like nan, resulting an empty mm_embedding, and further failures
  • so instead of using fake model (llava-354m), let's start using a real yet small vision model (smolVLM)

The model is copied from HuggingFaceTB/SmolVLM-256M-Instruct following this instruction

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(
    • Manually tested: install vllm0.8.2 locally, unit tests pass

Signed-off-by: Linkun Chen <github@lkchen.net>
@lk-chen lk-chen requested a review from a team as a code owner March 31, 2025 19:45
Copy link
Contributor

@GeneDer GeneDer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@kouroshHakha kouroshHakha enabled auto-merge (squash) March 31, 2025 20:38
Signed-off-by: Linkun Chen <github@lkchen.net>
@github-actions github-actions bot added the go add ONLY when ready to merge, run all tests label Mar 31, 2025
@github-actions github-actions bot disabled auto-merge March 31, 2025 20:39
@kouroshHakha kouroshHakha merged commit bedf579 into ray-project:master Mar 31, 2025
5 checks passed
@lk-chen lk-chen deleted the smolvlm-for-test branch March 31, 2025 22:06
pavelkushtia pushed a commit to pavelkushtia/ray that referenced this pull request Apr 6, 2025
Signed-off-by: Linkun Chen <github@lkchen.net>
vickytsang pushed a commit to ROCm/ray that referenced this pull request May 5, 2025
Signed-off-by: Linkun Chen <github@lkchen.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go add ONLY when ready to merge, run all tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants