postproc: imx500: Use new ioctl for network weight loading #825
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace the use of the custom V4L2 control for passing the network weights file to the driver with the custom ioctl that was recently added to the driver. This necessitates reading the file in userspace since the driver now expects to be passed a buffer rather than the file descriptor. Signed-off-by: Daniel Scally <dan.scally@ideasonboard.com>
djrscally
commented
Jun 17, 2025
| struct imx500_network_weights network_weights; | ||
|
|
||
| network_weights.size = stat.st_size; | ||
| network_weights.data = malloc(stat.st_size); |
There was a problem hiding this comment.
Naturally, the moment I opened the PR I noticed that I never free this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello
Working with the imx500 lately, the requirement for the network weights to be passed as a file descriptor gave me some pause, as I was instead storing them as database objects which meant I'd have had to write them out before passing them to the driver. I thought that switching the interface to expect a buffer / size would be a bit more flexible and possibly also a bit more upstream friendly. I opened a pull request for the kernel to implement that: raspberrypi/linux#6904. This pull request updates rpicam-apps to use the new ioctl instead of the removed control.
Thanks
Dan