drivers: media: rpi: cfe: Avoid unpack operation for 16-bit formats #6926
Conversation
| @@ -884,7 +884,9 @@ static void cfe_start_channel(struct cfe_node *node) | |||
| width = source_fmt->width; | |||
| height = source_fmt->height; | |||
|
|
|||
| if (node->vid_fmt.fmt.pix.pixelformat == | |||
| /* We don't need to repack in the case of 16-bit output. */ | |||
| if (fmt.depth != 16 && | |||
There was a problem hiding this comment.
Groan, I even had that locally!
The unpack operation is redundant for 16-bit sensor formats, don't set the hardware to do it in these cases. Signed-off-by: Naushir Patuck <naush@raspberrypi.com>
|
@njhollinghurst sadly I think this fix is only partially complete. We only remove the REMAP mode for direct CSI-2 output, not the FE output. From reading the spec, if |
|
Yes, the only workaround when using FE is to use the 'wildcard' DT (which is equivalent to reverting 98b1f0d) with the side-effect that it will then capture metadata and other DTs. FE could in theory crop out the different components, but better to avoid FE altogether if we can. |
|
Merging this now as it's correct, but fixing the core issue still needs quite a bit of additional work. |
The unpack operation is redundant for 16-bit sensor formats, don't set the hardware to do it in these cases.