-
Notifications
You must be signed in to change notification settings - Fork 20
Use twine
to upload wheels
#286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use twine
to upload wheels
#286
Conversation
The `gh-action-pypi-publish` action does not officially support self-hosted runners, so publish from a GitHub runner instead. Resolves NVIDIA/numba-cuda#75
ubuntu-latest
twine
to upload images
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The gh-action-pypi-publish action is having problems with some repos. Try uploading with twine instead.
What are the problems, specifically? I'd like to know that before reviewing.
From https://github.com/rapidsai/pynvjitlink/actions/runs/13730908249/job/38407961979#step:9:106:
|
Oh. I thought that specific problem was something we thought was related to running on self-hosted runners, and that we thought could be fixed by just switching to the GitHub Actions I have one more idea we could try.... could we running Removing this: shared-workflows/.github/workflows/wheels-publish.yaml Lines 51 to 56 in f1fb5d9
And then doing whatever's required to make the relevant bits of I just searched around and found some discussion suggesting that this type of issue might be something known and related to how that action sets paths when run in a container: |
Yes, James is right, see rapidsai/pynvjitlink#132 (comment) most recently. |
Even if we did move it outside of the container, there are still other issues, like the fact that we're using it from a reusable workflow. I think we should use |
You can do that at the cost of losing the ability to
But even if you go this route, you can still improve security a little bit by storing the in-repo secrets within GitHub Environments scope as opposed to having them repo-global in the settings. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This worked for the pynvjitlink 0.5.2 release! Approving.
With rapidsai/shared-workflows#286 merged, we no longer need to use a test branch from shared-workflows.
With rapidsai/shared-workflows#286 merged, we no longer need to use a test branch from shared-workflows. <!-- Thank you for contributing to pynvjitlink :) Here are some guidelines to help the review process go smoothly. 1. Please write a description in this text box of the changes that are being made. 2. Please ensure that you have written units tests for the changes made/features added. 3. If you are closing an issue please use one of the automatic closing words as noted here: https://help.github.com/articles/closing-issues-using-keywords/ 4. If your pull request is not ready for review but you want to make use of the continuous integration testing facilities please label it with `[WIP]`. 5. If your pull request is ready to be reviewed without requiring additional work on top of it, then remove the `[WIP]` label (if present) and replace it with `[REVIEW]`. If assistance is required to complete the functionality, for example when the C/C++ code of a feature is complete but Python bindings are still required, then add the label `[HELP-REQ]` so that others can triage and assist. The additional changes then can be implemented on top of the same PR. If the assistance is done by members of the rapidsAI team, then no additional actions are required by the creator of the original PR for this, otherwise the original author of the PR needs to give permission to the person(s) assisting to commit to their personal fork of the project. If that doesn't happen then a new PR based on the code of the original PR can be opened by the person assisting, which then will be the PR that will be merged. 6. Once all work has been done and review has taken place please do not add features or make changes out of the scope of those requested by the reviewer (doing this just add delays as already reviewed code ends up having to be re-reviewed/it is hard to tell what is new etc!). Further, please do not rebase your branch on main/force push/rewrite history, doing any of these causes the context of any comments made by reviewers to be lost. If conflicts occur against main they should be resolved by merging main into the branch used for making the pull request. Many thanks in advance for your cooperation! -->
Deleting (only Can always restore the branch if needed |
The
gh-action-pypi-publish
action is having problems with some repos. Try uploading withtwine
instead.