Skip to content

Conversation

kingcrimsontianyu
Copy link
Contributor

@kingcrimsontianyu kingcrimsontianyu commented Oct 16, 2025

This small PR fixes an out-of-bounds memory access that happens when the file open flags consist of a single character (e.g. "r" or "w" without the "+" suffix).

@copy-pr-bot
Copy link

copy-pr-bot bot commented Oct 16, 2025

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@kingcrimsontianyu kingcrimsontianyu added bug Something isn't working non-breaking Introduces a non-breaking change c++ Affects the C++ API of KvikIO labels Oct 16, 2025
@kingcrimsontianyu kingcrimsontianyu marked this pull request as ready for review October 16, 2025 15:53
@kingcrimsontianyu kingcrimsontianyu requested a review from a team as a code owner October 16, 2025 15:53
@kingcrimsontianyu
Copy link
Contributor Author

This bug remains undetected by valgrind likely due to the small string optimization (SSO) in the C++ library.

@kingcrimsontianyu
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 21fb8a5 into rapidsai:branch-25.12 Oct 16, 2025
80 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working c++ Affects the C++ API of KvikIO non-breaking Introduces a non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants