Skip to content

Add support for list type in get #20332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 22, 2025
Merged

Add support for list type in get #20332

merged 2 commits into from
Oct 22, 2025
+18 −0

Conversation

galipremsagar
Copy link
Contributor

Description

Closes: #20326

There are instances where we result in list type in StringMethods, for which pandas returns object dtype. But calling .str.xyz on that result is technically allowed and valid for some APIs. This is pr enables list type for .str.get API.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@galipremsagar galipremsagar self-assigned this Oct 21, 2025
@galipremsagar galipremsagar requested a review from a team as a code owner October 21, 2025 22:51
@galipremsagar galipremsagar added bug Something isn't working 3 - Ready for Review Ready for review by team labels Oct 21, 2025
@galipremsagar galipremsagar added the non-breaking Non-breaking change label Oct 21, 2025
@github-actions github-actions bot added the Python Affects Python cuDF API. label Oct 21, 2025
@GPUtester GPUtester moved this to In Progress in cuDF Python Oct 21, 2025
mroeschke
mroeschke approved these changes Oct 21, 2025
View reviewed changes
Copy link
Contributor

@mroeschke mroeschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just FYI StructDtype may need the same treatment for .get as I think pandas allows that API for dict data

@galipremsagar
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit d3ce8be into rapidsai:main Oct 22, 2025
132 checks passed
@galipremsagar galipremsagar added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 3 - Ready for Review Ready for review by team labels Oct 22, 2025
@github-project-automation github-project-automation bot moved this from In Progress to Done in cuDF Python Oct 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mroeschke mroeschke mroeschke approved these changes

@TomAugspurger TomAugspurger Awaiting requested review from TomAugspurger TomAugspurger is a code owner automatically assigned from rapidsai/cudf-python-codeowners

Assignees

@galipremsagar galipremsagar

Labels

5 - Ready to Merge Testing and reviews complete, ready to merge bug Something isn't working non-breaking Non-breaking change Python Affects Python cuDF API.

Projects

cuDF Python
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[BUG] .get on ListColumns is broken

2 participants

@galipremsagar @mroeschke