-
Notifications
You must be signed in to change notification settings - Fork 961
🚧 Add an example read a parquet file with highly selective filter using the next-gen parquet reader #19469
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
mhaseeb123
wants to merge
57
commits into
rapidsai:branch-25.10
Choose a base branch
from
mhaseeb123:fea/hybrid-scan-example
base: branch-25.10
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
🚧 Add an example read a parquet file with highly selective filter using the next-gen parquet reader #19469
mhaseeb123
wants to merge
57
commits into
rapidsai:branch-25.10
from
mhaseeb123:fea/hybrid-scan-example
+1,694
−67
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://github.com/mhaseeb123/cudf into fea/materialize-hybrid-scan-columns
https://github.com/mhaseeb123/cudf into fea/materialize-hybrid-scan-columns
https://github.com/mhaseeb123/cudf into fea/materialize-hybrid-scan-columns
…put-nullmasks-for-pruned-pages' into fea/materialize-hybrid-scan-columns
3 tasks
…mns' into fea/hybrid-scan-example
Signed-off-by: Muhammad Haseeb <14217455+mhaseeb123@users.noreply.github.com>
3 tasks
mhaseeb123
commented
Jul 29, 2025
out_columns.emplace_back(make_column(_output_buffers[i], &col_name, metadata, _stream)); | ||
} else { | ||
out_columns.emplace_back(make_column(_output_buffers[i], nullptr, metadata, _stream)); | ||
} | ||
} | ||
|
||
out_columns = |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copy pasted this stuff from the same function in reader_impl.cpp
to sync both versions. I believe this adds optimizations for structs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
2 - In Progress
Currently a work in progress
CMake
CMake build issue
DO NOT MERGE
Hold off on merging; see PR for details
feature request
New feature or request
libcudf
Affects libcudf (C++/CUDA) code.
non-breaking
Non-breaking change
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
🚧 This PR adds an example for reading a parquet file subject to highly selective string point lookup filter using the new next-gen (hybrid scan) reader. The file is also read using the legacy parquet reader and the timings are compared.
Checklist