Skip to content

Improve readability when printing pylibcudf enums #19451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Jul 28, 2025
Merged

Improve readability when printing pylibcudf enums #19451

merged 9 commits into from
Jul 28, 2025
+100 −13

Conversation

Matt711
Copy link
Contributor

@Matt711 Matt711 commented Jul 22, 2025 •
edited
Loading

Description

This PR makes readability better when printing public enums in pylibcudf by setting __str__ = __repr__

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@Matt711 Matt711 requested a review from a team as a code owner July 22, 2025 02:24
@Matt711 Matt711 added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Jul 22, 2025
@Matt711 Matt711 requested review from wence- and mroeschke July 22, 2025 02:24
@github-actions github-actions bot added Python Affects Python cuDF API. pylibcudf Issues specific to the pylibcudf package labels Jul 22, 2025
@Matt711 Matt711 changed the title Make pylibcudf enums set __str__ = __repr__ Improve redability when printing pylibcudf enums Jul 22, 2025
@GPUtester GPUtester moved this to In Progress in cuDF Python Jul 22, 2025
@Matt711 Matt711 changed the title Improve redability when printing pylibcudf enums Improve readability when printing pylibcudf enums Jul 22, 2025
wence-
wence- approved these changes Jul 25, 2025
View reviewed changes
Copy link
Contributor

@wence- wence- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Matt

@Matt711
Copy link
Contributor Author

Matt711 commented Jul 25, 2025

/ok to test 83b015b

Matt711
Matt711 commented Jul 25, 2025
View reviewed changes
@Matt711 Matt711 mentioned this pull request Jul 28, 2025
Merged
3 tasks
Matt711
Matt711 commented Jul 28, 2025
View reviewed changes
Matt711
Matt711 commented Jul 28, 2025
View reviewed changes
@Matt711
Copy link
Contributor Author

Matt711 commented Jul 28, 2025

/merge

@rapids-bot rapids-bot bot merged commit a6de670 into rapidsai:branch-25.10 Jul 28, 2025
90 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in cuDF Python Jul 28, 2025
rapids-bot bot pushed a commit that referenced this pull request Jul 29, 2025
@Matt711
Expose nvtext::letter_type to python (#19520)
67dae5d 
This PR exposes `nvtext::letter_type` enum and improves readability when printing it. See also #19451

Authors:
  - Matthew Murray (https://github.com/Matt711)

Approvers:
  - Matthew Roeschke (https://github.com/mroeschke)
  - Kyle Edwards (https://github.com/KyleFromNVIDIA)

URL: #19520
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wence- wence- wence- approved these changes

@mroeschke mroeschke Awaiting requested review from mroeschke mroeschke is a code owner automatically assigned from rapidsai/cudf-python-codeowners

Assignees

@Matt711 Matt711

Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change pylibcudf Issues specific to the pylibcudf package Python Affects Python cuDF API.
Projects
cuDF Python
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Matt711 @wence-