Skip to content

Updated libcudf-example conda package to preserve directories structure #19440

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 6 commits into
base: branch-25.10
Choose a base branch
from
Open

Updated libcudf-example conda package to preserve directories structure #19440

wants to merge 6 commits into from

Conversation

Avinash-Raj
Copy link

@Avinash-Raj Avinash-Raj commented Jul 19, 2025 •
edited
Loading

Description

Currently, the libcudf-example conda package installs all example files into a single directory, making it hard to identify which files belong to each example. This PR resolves the issue by organizing the files into respective subfolders.

closes #19360

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@Avinash-Raj Avinash-Raj requested a review from a team as a code owner July 19, 2025 13:06
@copy-pr-bot copy-pr-bot
Copy link

copy-pr-bot bot commented Jul 19, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@github-actions github-actions bot added libcudf Affects libcudf (C++/CUDA) code. CMake CMake build issue labels Jul 19, 2025
@ttnghia
Copy link
Contributor

ttnghia commented Jul 20, 2025 •
edited
Loading

Please provide a PR description. It will be used in commit log. "addressing XXX" or `closes XXX" showing up in commit log doesn't make any sense.

@GregoryKimball GregoryKimball moved this to Burndown in libcudf Jul 21, 2025
mhaseeb123
mhaseeb123 requested changes Jul 22, 2025
View reviewed changes
Copy link
Member

@mhaseeb123 mhaseeb123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also need to make changes to this file https://github.com/rapidsai/cudf/blob/branch-25.08/ci/run_cudf_examples.sh so that the examples may properly run in CI as well

@mhaseeb123 mhaseeb123 added 0 - Waiting on Author Waiting for author to respond to review non-breaking Non-breaking change ci improvement Improvement / enhancement to an existing function labels Jul 23, 2025
@Avinash-Raj Avinash-Raj requested a review from a team as a code owner July 25, 2025 00:48
@Avinash-Raj Avinash-Raj requested review from msarahan and mhaseeb123 and removed request for a team July 25, 2025 00:48
@Avinash-Raj
Copy link
Author

@mhaseeb123 Thanks for the heads-up. I've updated the relevant CI script.

@mhaseeb123 mhaseeb123 added 4 - Needs Review Waiting for reviewer to review or respond and removed 0 - Waiting on Author Waiting for author to respond to review labels Jul 25, 2025
@mhaseeb123 mhaseeb123 changed the base branch from branch-25.08 to branch-25.10 July 25, 2025 04:28
mhaseeb123
mhaseeb123 approved these changes Jul 25, 2025
View reviewed changes
Copy link
Member

@mhaseeb123 mhaseeb123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me now

@mhaseeb123
Copy link
Member

Looks like there are some merge conflicts. Let's resolve them and have the CI run on these :)

@mhaseeb123 mhaseeb123 removed the status in libcudf Jul 25, 2025
@Avinash-Raj Avinash-Raj requested a review from mhaseeb123 July 25, 2025 09:15
@mhaseeb123
Copy link
Member

/ok to test fac1a74

@mhaseeb123 mhaseeb123 removed their assignment Jul 25, 2025
@bdice
Copy link
Contributor

bdice commented Jul 25, 2025

@Avinash-Raj Can you take a look at the style check failures? See https://github.com/rapidsai/cudf/blob/branch-25.10/CONTRIBUTING.md#code-formatting for help on using pre-commit.

@Avinash-Raj Avinash-Raj requested a review from ttnghia July 28, 2025 16:42
@Avinash-Raj
Copy link
Author

Thanks @bdice, this pull request is ready for further review.

@mhaseeb123
Copy link
Member

/ok to test 548bfe0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msarahan msarahan Awaiting requested review from msarahan msarahan is a code owner automatically assigned from rapidsai/ci-codeowners

@mhaseeb123 mhaseeb123 Awaiting requested review from mhaseeb123

@ttnghia ttnghia Awaiting requested review from ttnghia

At least 1 approving review is required to merge this pull request.

Assignees

@Avinash-Raj Avinash-Raj

Labels
4 - Needs Review Waiting for reviewer to review or respond ci CMake CMake build issue improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
libcudf
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEA] Update the libcudf-example conda package to preserve directories
4 participants
@Avinash-Raj @ttnghia @mhaseeb123 @bdice