Skip to content

Use more pytest fixtures and avoid GPU parameterization in test_query/rank/reduction/repr.py #19434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: branch-25.10
Choose a base branch
from

Conversation

mroeschke
Copy link
Contributor

Description

Towards #9999

  • Use more pytest fixtures
  • Avoids pytest.mark.parametrize with GPU objects
  • Uses more context managers so state doesn't get altered if a test fails
  • python/cudf/cudf/tests/test_query_mask.py contained essentially the same test multiple times, so it was moved to test_query.py

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@mroeschke mroeschke self-assigned this Jul 18, 2025
@mroeschke mroeschke requested a review from a team as a code owner July 18, 2025 18:53
@mroeschke mroeschke added Python Affects Python cuDF API. improvement Improvement / enhancement to an existing function labels Jul 18, 2025
@mroeschke mroeschke added the non-breaking Non-breaking change label Jul 18, 2025
@GPUtester GPUtester moved this to In Progress in cuDF Python Jul 18, 2025
@mroeschke mroeschke changed the title Use more pytest fixtures and avoid GPU parameterization in cuDF classic tests Use more pytest fixtures and avoid GPU parameterization in test_query/rank/reduction/repr.py Jul 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

1 participant