Skip to content

Add support for Python 3.13 #18648

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
May 6, 2025
Merged

Conversation

gforsyth
Copy link
Contributor

@gforsyth gforsyth commented May 2, 2025

Description

Contributes to rapidsai/build-planning#120

This PR adds support for Python 3.13.

Notes for Reviewers

This is part of ongoing work to add Python 3.13 support across RAPIDS.
It temporarily introduces a build/test matrix including Python 3.13, from rapidsai/shared-workflows#268.

A follow-up PR will revert back to pointing at the branch-25.06 branch of shared-workflows once all
RAPIDS repos have added Python 3.13 support.

This will fail until all dependencies have been updated to Python 3.13

CI here is expected to fail until all of this project's upstream dependencies support Python 3.13.

This can be merged whenever all CI jobs are passing.

@gforsyth gforsyth added non-breaking Non-breaking change improvement Improvement / enhancement to an existing function labels May 2, 2025
Copy link

copy-pr-bot bot commented May 2, 2025

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@github-actions github-actions bot added Python Affects Python cuDF API. cudf.pandas Issues specific to cudf.pandas cudf.polars Issues specific to cudf.polars pylibcudf Issues specific to the pylibcudf package labels May 2, 2025
@gforsyth
Copy link
Contributor Author

gforsyth commented May 2, 2025

/ok to test

@gforsyth gforsyth marked this pull request as ready for review May 2, 2025 20:54
@gforsyth gforsyth requested review from a team as code owners May 2, 2025 20:54
@gforsyth gforsyth requested a review from msarahan May 2, 2025 20:54
@gforsyth gforsyth removed the request for review from msarahan May 2, 2025 21:14
@gforsyth
Copy link
Contributor Author

gforsyth commented May 5, 2025

closer on this one. waiting on cubinlinker conda packages for py313

@gforsyth gforsyth requested a review from a team as a code owner May 6, 2025 17:21
@gforsyth
Copy link
Contributor Author

gforsyth commented May 6, 2025

Added a few doctest skips for the failing doctests -- I think it's fine for us to not doctest output that's reliant on an upstream dependency

@bdice
Copy link
Contributor

bdice commented May 6, 2025

Added a few doctest skips for the failing doctests -- I think it's fine for us to not doctest output that's reliant on an upstream dependency

That's fine -- please open an issue to track this so that we can update it in the future if our NumPy lower bound is high enough to have matching behavior.

@gforsyth
Copy link
Contributor Author

gforsyth commented May 6, 2025

Opened tracking issue in #18685

@gforsyth
Copy link
Contributor Author

gforsyth commented May 6, 2025

/merge

@rapids-bot rapids-bot bot merged commit 607200d into rapidsai:branch-25.06 May 6, 2025
124 of 125 checks passed
@gforsyth gforsyth deleted the python-3.13 branch May 6, 2025 20:41
rapids-bot bot pushed a commit that referenced this pull request May 7, 2025
Support for Python 3.13 was added in #18648, however the
`cudf-pandas-unit-test` job requires some extra attention to refactor how it
pulls in compatible versions of Pandas (Python 3.13 support was added to Pandas
in version 2.2.3).

Until someone has time to investigate and fix that, moving this job away from
the Python 3.13 workflows to get nightlies passing.

Authors:
  - Gil Forsyth (https://github.com/gforsyth)
  - David Wendt (https://github.com/davidwendt)
  - Bradley Dice (https://github.com/bdice)

Approvers:
  - Bradley Dice (https://github.com/bdice)
  - GALI PREM SAGAR (https://github.com/galipremsagar)
  - Vyas Ramasubramani (https://github.com/vyasr)

URL: #18692
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cudf.pandas Issues specific to cudf.pandas cudf.polars Issues specific to cudf.polars improvement Improvement / enhancement to an existing function non-breaking Non-breaking change pylibcudf Issues specific to the pylibcudf package Python Affects Python cuDF API.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants