Enable reporting peak memory usage for gtests #18599
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidwendt
added
3 - Ready for Review
bdice
approved these changes
Apr 30, 2025
shrshi
reviewed
Apr 30, 2025
| @@ -122,5 +123,8 @@ TEST_F(BinaryopPTXTest, ColumnColumnPTX) | |||
|
|
|||
| cudf::binary_operation( | |||
| lhs, rhs, ptx, cudf::data_type(cudf::type_to_id<int32_t>()), cudf::test::get_default_stream()); | |||
| cudf::binary_operation(lhs, rhs, ptx, cudf::data_type(cudf::type_to_id<int64_t>())); | |||
| cudf::binary_operation( | |||
| lhs, rhs, ptx, cudf::data_type(cudf::type_to_id<int64_t>()), cudf::test::get_default_stream()); | |||
There was a problem hiding this comment.
Thank you for this fix! Not sure how the stream tests were passing earlier though 😕
shrshi
approved these changes
Apr 30, 2025
|
Here is the output as of this PR Perhaps there is a data-frame-ish library we could use to figure out how to group these appropriately for parallel processing by ctest. |
|
I would solve this a little differently -- perhaps more simply than the "optimal" strategy but easier to enforce. Currently we run our tests in CI with I filed PR #18603 with a proposal to run |
3 tasks
|
Updated This is 14GB |
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Enables libcudf gtests to report peak memory usage after the tests complete.
The memory peak uses the
rmm::mr::statistics_resource_adaptorand is triggered with the environment variableGTEST_CUDF_MEMORY_PEAKWorking on this uncovered that most of the
STREAM_based tests were not using theCUDF_TEST_PROGRAM_MAIN()and so did not support custom parameters. Also, at least one test failed the stream check after this was corrected.The PR includes a shell script to run each test and report the peak memory for each to stdout in CSV format.
Checklist