Skip to content

[3.x] Reduce javascript bundle size #604

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Dec 11, 2024
Merged

[3.x] Reduce javascript bundle size #604

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
5ff8ca8
Reduce javascript bundle size from 290kB to 156kB
Jade-GG Oct 21, 2024
f3e707a
Apply fixes from Prettier
Jade-GG Oct 21, 2024
d6d7696
Apply fixes from Prettier
rapidez-actions Oct 21, 2024
b639247
Merge branch 'master' into feature/js-minifications
Jade-GG Nov 7, 2024
b65572e
Merge remote-tracking branch 'upstream/master' into feature/js-minifi…
Jade-GG Dec 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions resources/js/components/Graphql.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ export default {
type: String,
},
check: {
type: String,
type: Function,
},
redirect: {
type: String,
Expand Down Expand Up @@ -80,7 +80,7 @@ export default {
: await magentoGraphQL(this.query, this.variables, options)

if (this.check) {
if (!eval('response?.data?.' + this.check)) {
if (!this.check(response?.data)) {
Turbo.visit(window.url(this.redirect))
return false
}
Expand Down
3 changes: 1 addition & 2 deletions resources/js/package.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,14 +15,13 @@ import useMask from './stores/useMask'
import { swatches, clear as clearSwatches } from './stores/useSwatches'
import { clear as clearAttributes } from './stores/useAttributes.js'
import './vue'
import { computed } from 'vue'
import './fetch'
import './filters'
import './mixins'
import './turbolinks'
import './cookies'
import './callbacks'
import './vue-components'
;(() => import('./turbolinks'))()

function init() {
// https://vuejs.org/api/application.html#app-config-performance
Expand Down
2 changes: 1 addition & 1 deletion resources/js/turbolinks.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,4 @@ import * as Turbo from '@hotwired/turbo'
import TurbolinksAdapter from 'vue-turbolinks'
Vue.use(TurbolinksAdapter)

Turbo.setProgressBarDelay(5)
Turbo.config.drive.progressBarDelay = 5
Loading