Skip to content

[3.x] Fix getCart query & styling for payment step & button label #148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 3, 2024
Merged

[3.x] Fix getCart query & styling for payment step & button label #148

merged 3 commits into from
Dec 3, 2024

Conversation

@Jade-GG
Copy link
Collaborator

@Jade-GG Jade-GG commented Dec 2, 2024 •
edited
Loading

  • The query was missed in the upgrade to 3.x
  • The button has one use case in confira where it becomes a label. Took the same code from the core
  • The payment step needs a gap between payment methods

@Jade-GG Jade-GG requested a review from indykoning December 2, 2024 12:33
@Jade-GG Jade-GG changed the title [3.x] Fix getCart query [3.x] Fix getCart query & styling for payment step & button label Dec 2, 2024
@royduin royduin merged commit 269fbe5 into master Dec 3, 2024
1 check failed
@royduin royduin deleted the Jade-GG-patch-1 branch December 3, 2024 09:17
This was referenced Dec 11, 2024
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@indykoning indykoning Awaiting requested review from indykoning

@jordythevulder jordythevulder Awaiting requested review from jordythevulder

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Jade-GG @royduin