Skip to content

Conversation

@Roene-JustBetter
Copy link
Member

This could be breaking for projects where you use custom breakpoints .

I changed some breakpoints because on 768px there is not enough space for a sidebar.

Jade-GG
Jade-GG previously approved these changes Oct 31, 2024
@royduin
Copy link
Member

royduin commented Nov 1, 2024

So a good idea to create a major release for this? Maybe together with v3 support: #118

jordythevulder
jordythevulder previously approved these changes Nov 1, 2024
@Roene-JustBetter
Copy link
Member Author

So a good idea to create a major release for this? Maybe together with v3 support: #118

@royduin Could be but it is not really breaking. I changed the breakpoints for example from sm (640px) to md (768px). If you changed the breakpoints in your project for example:

screens: {
  sm: '768px',
  md: '992px',
  lg: '1280px',
},

The layout will be changed when the screen size is992px instead of the default tailwind: 768px

@royduin royduin changed the base branch from master to 2.x November 5, 2024 09:03
@royduin royduin dismissed stale reviews from JimmyHoenderdaal, jordythevulder, and Jade-GG November 5, 2024 09:03

The base branch was changed.

@royduin royduin merged commit 46c16de into 2.x Nov 5, 2024
@royduin royduin deleted the feature/change-breakpoints branch November 5, 2024 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants