[3.x] Add translation checker workflow #123
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
indykoning
reviewed
Oct 30, 2024
royduin
reviewed
Oct 31, 2024
|
The workflow is failing now, is that correct? |
Correct, at this point the translations from the core are missing---those haven't been released yet (i.e. Rapidez 3.x hasn't been released yet). Once those are released and the composer.json gets updated with 3.x, then we'll get the core translations merged in and the workflow will succeed 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the translation checker workflow. Will show missing translations for now as it's missing the translations coming from the core itself (those are only in 3.x), however that will be resolved once the composer require is set to 3.x