-
Notifications
You must be signed in to change notification settings - Fork 27
Security best practices #298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| # capabilities: | ||
| # drop: | ||
| # - ALL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Question: can't we drop all caps?
| # capabilities: | ||
| # drop: | ||
| # - ALL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same comment as above.
| # capabilities: | ||
| # drop: | ||
| # - ALL | ||
| # privileged: false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And what about this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I didn't understand your concern here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, the comment is about line 197 - # privileged: false, but the UI rendered it as if it was for everything above.
My question is if we can explicitly set it to privileged: false.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it! I changed it to explicitly set the value to false
f13cf04 to
f5f6c93
Compare
macedogm
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Made a suggestion on a line that I believe was missed. Additionally, can we set?
capabilities:
drop:
- ALL
f5f6c93 to
40bc06d
Compare
|
As @macedogm mentioned, if possible we should drop all capabilities by default. If it disrupts the application flow, then we can at least try dropping as many capabilities as we can by default. Otherwise LGTM |
40bc06d to
2b5519a
Compare
Issue #291