Add UserID logging to HelmOp and BundleDeployment reconciliers #4249
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weyfonk
reviewed
Oct 20, 2025
weyfonk
approved these changes
Oct 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HelmOps resources do not provide the UserID label yet, because it is not implemented in the Rancher UI for now.
But as soon as the label is added, it will be used for HelmOps logging.
Additionally the UserID logging was added to the BundleDeployment controller too, to be consistent. The bundles distribute the label to the BundleDeployments.
Follow up to #4202
Refers to #3424
QA Consideration
Same as mentioned in #3424 (comment). The only difference is that Rancher UI does not add the UserID label for HelmOp bundles yet, so this would need to be done manually to see if it is used for logging.