Skip to content

Conversation

thardeck
Copy link
Collaborator

@thardeck thardeck commented Oct 16, 2025

Unlike Endpoints, EndpointSlices are controller managed. That's why there are not canonical normalization or sort functions for them.

EndpointSlices should not be relevant for the Fleet drift detection, since they should not be part of the user manifest, because they are auto generated.

This reverts commit 4d06c2a.

But keeps the comments in regards to Endpoint support.

Refers to #3760

This reverts commit 4d06c2a.

But keeps the comments in regards to Endpoint support.
@thardeck thardeck self-assigned this Oct 16, 2025
@thardeck thardeck requested a review from a team as a code owner October 16, 2025 14:59
@thardeck thardeck marked this pull request as draft October 16, 2025 15:58
@thardeck thardeck marked this pull request as ready for review October 20, 2025 12:55
@thardeck thardeck added this to Fleet Oct 21, 2025
@thardeck thardeck moved this to 👀 In review in Fleet Oct 21, 2025
@thardeck thardeck merged commit 6e5e4a9 into main Oct 21, 2025
48 of 50 checks passed
@thardeck thardeck deleted the remove_obsolete_endpointslice_normalization branch October 21, 2025 10:18
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in Fleet Oct 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants