Remove deprecated created-by label #4225
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was added by Rancher UI but was redundant because of the additional label `created-by-user-id`.
thardeck
force-pushed
the
add_label_migration
branch
from
410ba0c to
21c8f5c
Compare
weyfonk
reviewed
Oct 16, 2025
weyfonk
approved these changes
Oct 17, 2025
thardeck
added a commit
that referenced
this pull request
Oct 20, 2025
It was added by Rancher UI but was redundant because of the additional label `created-by-user-id`.
thardeck
added a commit
that referenced
this pull request
Oct 20, 2025
It was added by Rancher UI but was redundant because of the additional label `created-by-user-id`.
thardeck
added a commit
that referenced
this pull request
Oct 20, 2025
It was added by Rancher UI but was redundant because of the additional label `created-by-user-id`.
thardeck
added a commit
that referenced
this pull request
Oct 20, 2025
It was added by Rancher UI but was redundant because of the additional label `created-by-user-id`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fleet.cattle.io/created-by-display-namewas added by Rancher UI but was redundant because of the additional labelfleet.cattle.io/created-by-user-id.Additional QA
Testing
Automated Testing
Added integration tests to verify that the deprecated label
fleet.cattle.io/created-by-display-nameis removed if it exists.QA Testing Considerations
fleet.cattle.io/created-by-display-nameis gone butfleet.cattle.io/created-by-user-idis still there.Regressions Considerations
fleet.cattle.io/created-by-user-idand other user labels should not be affected by the migration.