Skip to content

Conversation

weyfonk
Copy link
Contributor

@weyfonk weyfonk commented Sep 30, 2025

This reduces flakiness of end-to-end tests relying on OCI registries in the following way:

  • When an outdated OCI reference secret is expected to be deleted, testing logic uses an Eventually block to wait for that deletion to happen, instead of expecting immediate deletion.

Additional Information

Checklist

- [ ] I have updated the documentation via a pull request in the
fleet-docs repository.

@weyfonk weyfonk requested a review from a team as a code owner September 30, 2025 09:47
@weyfonk weyfonk force-pushed the fix-flaky-oci-registry-e2e branch from 0ef4ca1 to 697ff65 Compare September 30, 2025 09:48
@weyfonk weyfonk added this to Fleet Sep 30, 2025
@weyfonk weyfonk moved this to 👀 In review in Fleet Sep 30, 2025
@weyfonk weyfonk marked this pull request as draft September 30, 2025 10:08
@weyfonk weyfonk removed the status in Fleet Oct 2, 2025
@weyfonk weyfonk force-pushed the fix-flaky-oci-registry-e2e branch from 697ff65 to 2e4a0d0 Compare October 7, 2025 14:09
@weyfonk weyfonk marked this pull request as ready for review October 7, 2025 14:23
@weyfonk weyfonk moved this to 👀 In review in Fleet Oct 7, 2025
@weyfonk weyfonk changed the title Wait for OCI artifact to be deleted Reduce flakiness of OCI end-to-end tests Oct 7, 2025
@thardeck thardeck enabled auto-merge (rebase) October 8, 2025 08:32
@thardeck thardeck disabled auto-merge October 8, 2025 08:50
Using an `Eventually` block instead of expecting immediate deletion
should reduce flakiness.
The token was missing, making the end-to-end test case for token-based
auth fail in nightly runs.
@weyfonk weyfonk force-pushed the fix-flaky-oci-registry-e2e branch from 7490302 to f838a22 Compare October 13, 2025 14:54
@weyfonk weyfonk merged commit 2a5b433 into rancher:main Oct 13, 2025
22 of 23 checks passed
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in Fleet Oct 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants